Standardize values #447
Closed
Standardize values #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naseemkullah
force-pushed
the
standardize-values
branch
from
e9c23f3 to
5e464fc
Compare
|
We need to do some further checks on this as a few dependent projects for our Marketplace release depend on the core chart for GCP marketplace and AWS Marketplace |
|
Sounds good, thanks! |
|
We also need to look at all the references in the seldon-core repo to these properties via |
|
I am closing this as we have changed our helm install so seldon-core chart is no longer used and will be removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of PR #445 but did not want to put too much in 1 PR.
After it gets approved, please consider this PR.
It follows more standardized helm practices which makes the chart more familiar to users of stable helm chart.