Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix top nav bar colour and typo in README #879

Merged
merged 15 commits into from
Sep 21, 2019

Conversation

MarcoGorelli
Copy link
Contributor

closes #878

@seldondev
Copy link
Collaborator

Hi @MarcoGorelli. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@seldondev seldondev added size/S and removed size/XS labels Sep 21, 2019
@seldondev seldondev added size/M and removed size/S labels Sep 21, 2019
@ukclivecox
Copy link
Contributor

Thanks. Very much appreciated.

@ukclivecox
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ukclivecox
Copy link
Contributor

/ok-to-test

@seldondev seldondev merged commit 3a7ce03 into SeldonIO:master Sep 21, 2019
@MarcoGorelli MarcoGorelli deleted the top-nav-bar branch September 21, 2019 19:29
@MarcoGorelli
Copy link
Contributor Author

Happy to help, thank you for seldon-core!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Top navigation bar doesn't use Seldon's pink (#ff4072), and README uses wrong form of "lets"
3 participants