Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove non-seldon runtimes #210

Merged
merged 2 commits into from
Nov 5, 2021
Merged

Remove non-seldon runtimes #210

merged 2 commits into from
Nov 5, 2021

Conversation

ukclivecox
Copy link
Contributor

@ukclivecox ukclivecox commented Nov 3, 2021 •
edited
Loading

  • Remove kfserving runtime
  • move protocols: v2, tensorflow, seldon to tempo/protocols

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@ukclivecox ukclivecox requested a review from axsaucedo November 3, 2021 16:50
@axsaucedo
Copy link
Contributor

Awesome - looks good overall, I really like the v2 protocol naming instead, seems some tests are failing and 3.8 ones aren't running

@axsaucedo
Copy link
Contributor

Merging as discussed as passes locally

@axsaucedo axsaucedo merged commit 5f5612f into SeldonIO:master Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axsaucedo axsaucedo Awaiting requested review from axsaucedo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ukclivecox @axsaucedo