Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code export doesn't provide error message for invalid commands #742

Closed
catalin-florescu opened this issue Jul 10, 2019 · 5 comments
Closed

Comments

@catalin-florescu
Copy link

catalin-florescu commented Jul 10, 2019

🐛 Bug Report

To Reproduce

Steps to reproduce the behavior:
Record a new script and save.

Right-click test and select Export

Export as Java Junit (or Python/JavaScript)

Click export.

Expected behavior

A clear and concise description of what you expected to happen.

Project file reproducing this issue (highly encouraged)

Expected Result: A File Save dialog appears.

Actual Result: No Dialog appears - no export can be

Environment

OS: MacOS Mojave 10.14.5
Selenium IDE Version: 3.11.0
Selenium SIDE Runner Version: N/A

Browser:
Browser Version: 75.0.3770.100 (Official Build) (64-bit)

@tourdedave
Copy link

@catalin-florescu can you attach a SIDE project file that this happens with?

@catalin-florescu
Copy link
Author

catalin-florescu commented Jul 10, 2019

The side file code

{ "id": "9d0fc554-9227-4a97-af3a-39668cab02c8", "version": "2.0", "name": "instagram", "url": "", "tests": [{ "id": "7df8e44b-32d5-400a-b98d-a21c11bd75a8", "name": "Instagram", "commands": [{ "id": "bf93d252-3f8d-419b-96d0-dff1dbff18e5", "comment": "", "command": "open", "target": "", "targets": [], "value": "" }, { "id": "24fa2679-27a4-4ef9-ad1e-ac8d91fa3f33", "comment": "", "command": "setWindowSize", "target": "", "targets": [], "value": "" }, { "id": "7bd8ec56-724a-4a60-a9a2-56c6b5ccac0b", "comment": "", "command": "close", "target": "", "targets": [], "value": "" }] }], "suites": [{ "id": "1185c3c6-d208-43ce-b8a3-7222b5dd179c", "name": "Default Suite", "persistSession": false, "parallel": false, "timeout": 300, "tests": ["7df8e44b-32d5-400a-b98d-a21c11bd75a8"] }], "urls": [], "plugins": [] }

@tourdedave

@tourdedave
Copy link

You have an incomplete command -- set window size. You need to specify a resolution size in the target input (e.g., 1024x768). I'll look into adding better error handling.

@tourdedave tourdedave changed the title Java, Python and JavaScrip Export non-function Code export doesn't provide error message for invalid commands Jul 10, 2019
@catalin-florescu
Copy link
Author

Nice! It works. Thanks! It will be better to show an error message when it can't export.

@tourdedave
Copy link

The fix is available now in v3.12.2 of the IDE.

@lock lock bot locked and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants