[py] use get_timeout() for urllib pool manager timeouts in remote connection, prevents passing the default socket object directly
#10563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## trunk #10563 +/- ##
=======================================
Coverage 45.03% 45.03%
=======================================
Files 85 85
Lines 5507 5507
Branches 268 268
=======================================
Hits 2480 2480
Misses 2759 2759
Partials 268 268
Continue to review full report at Codecov.
|
AutomatedTester
approved these changes
Apr 28, 2022
elgatov
pushed a commit
to elgatov/selenium
that referenced
this pull request
Jun 27, 2022
…onnection, prevents passing the default socket object directly (SeleniumHQ#10563) * pass the underlying `timeout` to urls pool manager * invoke the `get_timeout()` class method for `urllib` timeouts * fix class state leaking across tests for url lib timeouts; add unit test for default Co-authored-by: David Burns <[email protected]>
This was referenced Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed we are passing the
socket._GLOBAL_DEFAULT_TIMEOUTobject into theurllibpool manager which I think is a mistake; there already exists aget_timeout()that returnsNoneunder that instance; I think we should be calling that instead?A lot of this is class level state on the
RemoteConnectioninstance; should we move it into the instance and usesocket.getdefaulttimeout()? when setting this state it leaks across tests as a bad side effect of global state; so using monkeypatch to tidy up some of the impacted areas