Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print requested capabilities in SessionNotCreatedException #11604

Merged
merged 1 commit into from
Feb 2, 2023
Merged

print requested capabilities in SessionNotCreatedException #11604

merged 1 commit into from
Feb 2, 2023

Conversation

asolntsev
Copy link
Contributor

Description

Currently SessionNotCreatedException always prints out empty capabilities:

org.openqa.selenium.SessionNotCreatedException: Could not start a new session...
Host info: ...
Build info: version: '4.8.0'...
System info: ...
Driver info: ...
Command: [null, newSession...}]
Capabilities {}

	at org.openqa.selenium.remote.RemoteWebDriver.execute(RemoteWebDriver.java:561)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@codecov-commenter
Copy link

Codecov Report

Base: 54.65% // Head: 54.65% // No change to project coverage 👍

Coverage data is based on head (9ca1de0) compared to base (6bc5a58).
Patch has no changes to coverable lines.

❗ Current head 9ca1de0 differs from pull request most recent head cf7bf9e. Consider uploading reports for the commit cf7bf9e to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #11604   +/-   ##
=======================================
  Coverage   54.65%   54.65%           
=======================================
  Files          85       85           
  Lines        5643     5643           
  Branches      244      244           
=======================================
  Hits         3084     3084           
  Misses       2315     2315           
  Partials      244      244           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@diemol
Copy link
Member

diemol commented Feb 1, 2023

A couple of things are failing in our CI, we are checking them and after that will merge this PR. Thanks, @asolntsev!

without this change, `SessionNotCreatedException` always prints out empty capabilities:

```
org.openqa.selenium.SessionNotCreatedException: Could not start a new session...
Host info: ...
Build info: version: '4.8.0'...
System info: ...
Driver info: ...
Command: [null, newSession...}]
Capabilities {}

	at org.openqa.selenium.remote.RemoteWebDriver.execute(RemoteWebDriver.java:561)
```
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @asolntsev!

@diemol diemol merged commit 23782b3 into SeleniumHQ:trunk Feb 2, 2023
@asolntsev asolntsev deleted the fix/print-capabilities-in-session-not-created-exception branch March 8, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants