Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes two issues with
selenium.webdriver.common.bidi.cdp.BrowserError
:KeyError
can get raised when creating a newBrowserError
instance when the passedobj
dict/mapping doesn't have thecode
ormessage
keys.BrowserError
constructor, which would make it raise aTypeError
.Motivation and Context
devtools.fetch.enable
and it returns a response with theerror
key (error message irrelevant):selenium/py/selenium/webdriver/common/bidi/cdp.py
Lines 270 to 273 in 38e658a
That
error
dict however is missing thecode
key, hence theKeyError
being raised while trying to initialize the exception.Since both
code
andmessage
are now "optional", do you want me to add default values instead, e.g."unknown"
?selenium/py/selenium/webdriver/common/bidi/cdp.py
Line 438 in 38e658a
No updated tests, because I couldn't find any tests which affect these parts of the code.
Types of changes
Checklist