Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Increased the max depth of new session payload #12205

Merged
merged 2 commits into from
Jun 15, 2023

Conversation

joerg1985
Copy link
Member

Description

Made the max depth more flexible and increased the max depth of new session payload to 100.

Motivation and Context

fixes #12201

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@joerg1985 joerg1985 changed the title Increased the max depth of new session payload [java] Increased the max depth of new session payload Jun 15, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 88.05% and project coverage change: +0.29 🎉

Comparison is base (4d70bd8) 56.98% compared to head (8813188) 57.28%.

❗ Current head 8813188 differs from pull request most recent head ebdf47f. Consider uploading reports for the commit ebdf47f to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #12205      +/-   ##
==========================================
+ Coverage   56.98%   57.28%   +0.29%     
==========================================
  Files          86       86              
  Lines        5440     5487      +47     
  Branches      226      226              
==========================================
+ Hits         3100     3143      +43     
- Misses       2114     2118       +4     
  Partials      226      226              
Impacted Files Coverage Δ
py/selenium/types.py 75.00% <0.00%> (ø)
py/selenium/webdriver/common/bidi/cdp.py 22.64% <0.00%> (-0.33%) ⬇️
py/selenium/webdriver/common/service.py 89.92% <94.11%> (+0.09%) ⬆️
py/selenium/webdriver/chrome/service.py 85.71% <100.00%> (+2.38%) ⬆️
py/selenium/webdriver/chromium/service.py 90.90% <100.00%> (+5.90%) ⬆️
py/selenium/webdriver/edge/service.py 90.00% <100.00%> (+1.11%) ⬆️
py/selenium/webdriver/firefox/service.py 91.66% <100.00%> (+3.20%) ⬆️
py/selenium/webdriver/ie/service.py 90.00% <100.00%> (+2.00%) ⬆️
py/selenium/webdriver/safari/service.py 73.68% <100.00%> (-0.68%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @joerg1985!

@Yith1
Copy link

Yith1 commented Aug 21, 2023

There's still a problem. The toJson method is called by the AbstractHttpCommandCodec (at line 273) and the version that sets the default max depth to 10 is still being called.

This is causing the toJson method to fail with a tree depth error when we are using AxeReporter to report Accessibility problems. The depth of the structure returned is above the 10 maximum.

This is happening when AxeBuilder.analyze() is being called.

image

@titusfortner
Copy link
Member

Can you make a PR with a fix?

@Yith1
Copy link

Yith1 commented Aug 21, 2023

Can you make a PR with a fix?

I could, but I've never written any Selenium stuff before.

Yith1 pushed a commit to Yith1/selenium that referenced this pull request Aug 21, 2023
…xeBuilder.analyze() does not fail when processing results.

See comments on SeleniumHQ#12205
@Yith1
Copy link

Yith1 commented Aug 21, 2023

I'm not sure whether I've created the Pull Request properly, but here's the change.

I've tested it and it fixes my problem.
#12581

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Can't set chrome options due to JSON MAX_DEPTH
5 participants