-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[java] Increased the max depth of new session payload #12205
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## trunk #12205 +/- ##
==========================================
+ Coverage 56.98% 57.28% +0.29%
==========================================
Files 86 86
Lines 5440 5487 +47
Branches 226 226
==========================================
+ Hits 3100 3143 +43
- Misses 2114 2118 +4
Partials 226 226
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @joerg1985!
There's still a problem. The toJson method is called by the AbstractHttpCommandCodec (at line 273) and the version that sets the default max depth to 10 is still being called. This is causing the toJson method to fail with a tree depth error when we are using AxeReporter to report Accessibility problems. The depth of the structure returned is above the 10 maximum. This is happening when AxeBuilder.analyze() is being called. |
Can you make a PR with a fix? |
I could, but I've never written any Selenium stuff before. |
…xeBuilder.analyze() does not fail when processing results. See comments on SeleniumHQ#12205
I'm not sure whether I've created the Pull Request properly, but here's the change. I've tested it and it fixes my problem. |
Description
Made the max depth more flexible and increased the max depth of new session payload to 100.
Motivation and Context
fixes #12201
Types of changes
Checklist