Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bazel][java] No need to have the auto-service dependency in the client bindings #12244

Merged
merged 2 commits into from
Jun 23, 2023

Conversation

joerg1985
Copy link
Member

Description

The java client bindings will only need the auto-service-annotations dependency not the complete auto-service.

Motivation and Context

To have two (com.google.auto.service:auto-service and com.google.auto:auto-common) unused dependencies less on the java client.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@joerg1985 joerg1985 changed the title [bazel] No need to have the auto-service dependency in the client bindings [bazel][java] No need to have the auto-service dependency in the client bindings Jun 22, 2023
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @joerg1985!

@diemol diemol merged commit cb2560d into SeleniumHQ:trunk Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants