[IEDriver] Ignore process id match when finding the window handle - IE Mode on Edge. #12246
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This assumes a single Edge instance is running
on the host. Not suited for running sessions
in parallel, or having another Edge browser
manually at the same time, because it will
most likely lead to return the wrong window
handle.
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
#12091 describes the issue where running
IEDriver
combined with IE Mode on Edge under an admin window does not work. This happens because under these conditions Edge is launched in a forked process without privileges, and then the process idIEDriver
gets is different from the one it actually uses.This PR introduces a flag (
ie.ignoreprocessmatch
) which avoids the process id matching, andIEDriver
can use the launched Edge browser.Description
All the previous assumes a single Edge instance is running on the host. This is not suited for running sessions in parallel, or having another Edge browser opened manually at the same time, because it will most likely lead to return the wrong window handle.
Motivation and Context
Allows users to run
IEDriver
with IE Mode under admin shells with the caveats described above.Types of changes
Checklist