Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Really drop the prefix created by Bazel #12264

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

joerg1985
Copy link
Member

Description

This is the fix of a previous PR (#12173) i made, which was not working but merged. Sorry!

Motivation and Context

This PR will really drop the prefix created by Bazel from java module names. To ensure jdeps will also find the module derived from the jar name these jars need to be copied with the correct name.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04 ⚠️

Comparison is base (cb2560d) 57.28% compared to head (95f330a) 57.24%.

❗ Current head 95f330a differs from pull request most recent head 9e1b261. Consider uploading reports for the commit 9e1b261 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #12264      +/-   ##
==========================================
- Coverage   57.28%   57.24%   -0.04%     
==========================================
  Files          86       86              
  Lines        5487     5483       -4     
  Branches      226      226              
==========================================
- Hits         3143     3139       -4     
  Misses       2118     2118              
  Partials      226      226              
Impacted Files Coverage Δ
py/selenium/webdriver/common/driver_finder.py 100.00% <ø> (ø)
py/selenium/webdriver/common/selenium_manager.py 62.90% <ø> (-1.16%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @joerg1985!

@diemol diemol merged commit c3ecc3c into SeleniumHQ:trunk Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants