[py] Refactored Proxy object in common/proxy.py using custom descriptor. #12286
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Moved all below ProxyTypes which has common operations in
getter
andsetter
methods to one single descriptor class. Also, I have re-factoredto_capabilities
method by eliminating multiple conditionals.This is the same PR (12280) that I closed as I had some issues with the branch that I was working with.
In this PR, I have incorporated the change that @AutomatedTester had asked. (giving blank lines between docstring and descriptor object)
Motivation and Context
getters
andsetters
to custom descriptors, multiple properties are being eliminated.__set__
method of descriptor.to_capabilites
method in Proxy class by eliminating multiple conditional statements.Types of changes
Checklist