Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py] added type hints to SwitchTo class #12296

Merged

Conversation

sandeepsuryaprasad
Copy link
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Type Hinting support for SwitchTo class in remote/switch_to.py

Motivation and Context

Type Hinting support for SwitchTo class in remote/switch_to.py

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • [] I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2023

Codecov Report

Patch coverage: 87.50% and project coverage change: +0.14 🎉

Comparison is base (2fd7dd7) 56.92% compared to head (ca3ae18) 57.06%.

❗ Current head ca3ae18 differs from pull request most recent head 465b0f5. Consider uploading reports for the commit 465b0f5 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #12296      +/-   ##
==========================================
+ Coverage   56.92%   57.06%   +0.14%     
==========================================
  Files          86       86              
  Lines        5423     5425       +2     
  Branches      193      193              
==========================================
+ Hits         3087     3096       +9     
+ Misses       2143     2136       -7     
  Partials      193      193              
Impacted Files Coverage Δ
py/selenium/webdriver/remote/switch_to.py 54.16% <85.71%> (+17.21%) ⬆️
py/selenium/webdriver/ie/options.py 47.50% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AutomatedTester AutomatedTester merged commit 6002d14 into SeleniumHQ:trunk Jul 4, 2023
@sandeepsuryaprasad sandeepsuryaprasad deleted the type-hints-switch-to branch November 24, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants