Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py] minor ie-options fix to PR 12283 #12309

Merged

Conversation

sandeepsuryaprasad
Copy link
Contributor

@sandeepsuryaprasad sandeepsuryaprasad commented Jul 4, 2023

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

  • In PR 12283, all ie-options are being saved in uppercase variables. e.g. BROWSER_ATTACH_TIMEOUT ELEMENT_SCROLL_BEHAVIOR.
  • But all options must be saved in variable with camelCasing naming convention e.g. browserAttachTimeout, elementScrollBehavior. I have changed the code accordingly. Now all ie-options are being saved in variables with camel casing naming convention.

Motivation and Context

All ie-options should be saved in variable with camel casing naming convention as below.
browserAttachTimeout
elementScrollBehavior
ie.ensureCleanSession
ie.fileUploadDialogTimeout
ie.forceCreateProcessApi
ie.forceShellWindowsApi
ie.enableFullPageScreenshot
ignoreProtectedModeSettings
ignoreZoomSetting
initialBrowserUrl
nativeEvents
enablePersistentHover
requireWindowFocus
ie.usePerProcessProxy
ie.useLegacyFileUploadDialogHandling
ie.edgechromium
ie.edgepath
ie.ignoreprocessmatch

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • [] I have added tests to cover my changes.
  • All new and existing tests passed.

@AutomatedTester AutomatedTester merged commit f8240df into SeleniumHQ:trunk Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants