Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py] added type checks in setter methods of different browser options #12328

Merged
merged 5 commits into from
Jul 26, 2023

Conversation

sandeepsuryaprasad
Copy link
Contributor

@sandeepsuryaprasad sandeepsuryaprasad commented Jul 9, 2023

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Added type checks in setter methods of different browser options.

Motivation and Context

The type check was not being done before setting the values of some browser options (e.g binary_location) in setter methods of different browsers. I have added these validations in setter methods of below options.

  • chromium/options.py
  • firefox/options.py
  • safari/options.py
  • wpewebkit/options.py
  • safari/services.py

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • [] I have added tests to cover my changes.
  • All new and existing tests passed.

@AutomatedTester AutomatedTester merged commit 7c7790d into SeleniumHQ:trunk Jul 26, 2023
moritzj29 added a commit to moritzj29/finance-dl that referenced this pull request Nov 5, 2023
…is used (due to SeleniumHQ/selenium#12328 an empty `CHROMEDRIVER_CHROME_BINARY` is no longer allowed)
@sandeepsuryaprasad sandeepsuryaprasad deleted the binary-fix branch November 24, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants