Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[grid] reject requests only if it has been in the queue before trying… #12336

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

joerg1985
Copy link
Member

Description

Reject requests only if it has been in the queue before trying to create the sessions.

Motivation and Context

This fixes a race condition, when --reject-unsupported-caps is set to true and the request is added to the queue while the NewSessionRunnable is executed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3bebd42) 57.28% compared to head (1d46558) 57.28%.

❗ Current head 1d46558 differs from pull request most recent head 284a482. Consider uploading reports for the commit 284a482 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #12336   +/-   ##
=======================================
  Coverage   57.28%   57.28%           
=======================================
  Files          86       86           
  Lines        5333     5333           
  Branches      193      193           
=======================================
  Hits         3055     3055           
  Misses       2085     2085           
  Partials      193      193           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@joerg1985 joerg1985 force-pushed the new-session-race branch 3 times, most recently from f8151e5 to 3e1eb86 Compare July 14, 2023 19:47
@diemol diemol merged commit f13370b into SeleniumHQ:trunk Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants