Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rust] Enhance warning message when incorrect driver in PATH is detected #12395

Merged
merged 2 commits into from
Jul 21, 2023

Conversation

bonigarcia
Copy link
Member

Description

This PR enhances the warning message that Selenium Manager displays when an incompatible driver version is found in the PATH. Some example of the new message is as follows:

WARN The chromedriver version (107.0.5304.62) detected in PATH at C:\Users\boni\Documents\bat\chromedriver.exe might not be compatible with the detected chrome version (115.0.5790.99); currently, chromedriver 115.0.5790.102 is recommended for chrome 115.*, so it is advised to delete the driver in PATH and retry

Motivation and Context

This PR enhances the user experience with Selenium Manager for automated driver management.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (b22d08d) 57.28% compared to head (24df661) 57.28%.

❗ Current head 24df661 differs from pull request most recent head 13244ff. Consider uploading reports for the commit 13244ff to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #12395   +/-   ##
=======================================
  Coverage   57.28%   57.28%           
=======================================
  Files          86       86           
  Lines        5333     5333           
  Branches      193      193           
=======================================
  Hits         3055     3055           
  Misses       2085     2085           
  Partials      193      193           
Impacted Files Coverage Δ
py/selenium/webdriver/support/wait.py 70.58% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@diemol diemol merged commit 490de08 into trunk Jul 21, 2023
@diemol diemol deleted the se_mgr_warn_path branch July 21, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants