-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing #12469 - incompatible types error in mypy #12477
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## trunk #12477 +/- ##
==========================================
- Coverage 57.30% 57.26% -0.05%
==========================================
Files 86 86
Lines 5340 5335 -5
Branches 198 198
==========================================
- Hits 3060 3055 -5
Misses 2082 2082
Partials 198 198
☔ View full report in Codecov by Sentry. |
The Python/Lint github action failed on a file that wasn't changed in this PR. It would appear that the head of trunk has commits that failed as well. What is the proper course of action? Do I need to fix the linter errors from trunk in order to get the PR merged? |
Sorry @MarcelWilson that was caused by me, I fixed another bug on mobile and didn't have the benefit of being able to run the pre-commit linter hooks! - fixed in |
@symonk No worries! Contributing to a large project such as selenium is just a little intimidating. Thanks. |
Thanks for the fix! |
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Fixed the annotation assigned to
driver
argument inActionChains
so mypy will allow all drivers to be accepted.See #12469
Motivation and Context
Allows mypy to pass properly when passing remote webdriver into
ActionChains
Types of changes
Checklist