Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing #12469 - incompatible types error in mypy #12477

Merged
merged 3 commits into from
Aug 3, 2023

Conversation

bandophahita
Copy link
Contributor

@bandophahita bandophahita commented Aug 2, 2023

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Fixed the annotation assigned to driver argument in ActionChains so mypy will allow all drivers to be accepted.
See #12469

Motivation and Context

Allows mypy to pass properly when passing remote webdriver into ActionChains

Types of changes

  • [X ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [ X] I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • [X ] All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented Aug 2, 2023

CLA assistant check
All committers have signed the CLA.

@titusfortner titusfortner requested a review from symonk August 2, 2023 18:11
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.05% ⚠️

Comparison is base (fbfa5d2) 57.30% compared to head (b8e0f49) 57.26%.

❗ Current head b8e0f49 differs from pull request most recent head 1989995. Consider uploading reports for the commit 1989995 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #12477      +/-   ##
==========================================
- Coverage   57.30%   57.26%   -0.05%     
==========================================
  Files          86       86              
  Lines        5340     5335       -5     
  Branches      198      198              
==========================================
- Hits         3060     3055       -5     
  Misses       2082     2082              
  Partials      198      198              
Files Changed Coverage Δ
py/selenium/webdriver/common/action_chains.py 87.50% <100.00%> (-0.45%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcelWilson
Copy link

The Python/Lint github action failed on a file that wasn't changed in this PR. It would appear that the head of trunk has commits that failed as well.

What is the proper course of action? Do I need to fix the linter errors from trunk in order to get the PR merged?

@symonk
Copy link
Member

symonk commented Aug 2, 2023

Sorry @MarcelWilson that was caused by me, I fixed another bug on mobile and didn't have the benefit of being able to run the pre-commit linter hooks! - fixed in trunk and pulled into this branch

@MarcelWilson
Copy link

@symonk No worries! Contributing to a large project such as selenium is just a little intimidating. Thanks.

@titusfortner titusfortner merged commit 3df8b70 into SeleniumHQ:trunk Aug 3, 2023
@titusfortner
Copy link
Member

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants