Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fragment.bzl to fix a bug where "_" was overwritten #12704

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

mdmintz
Copy link
Contributor

@mdmintz mdmintz commented Sep 7, 2023

Update fragment.bzl to fix a bug where _ was overwritten

This resolves #12659

This reverts #12557

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

Update fragment.bzl to fix bug where "_" was overwritten
Copy link
Member

@titusfortner titusfortner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep the text that was deleted as well. Can you run git revert on it?

Update fragment.bzl (full revert)
@Jabbar2010
Copy link

Jabbar2010 commented Jun 13, 2024

Hi, @mdmintz @titusfortner @jarib @KazuCocoa there is an error on my side,
image
I found the root cause is from atoms, as this PR, you just add navigator and document from window, but no JSON
image
image
Besides above, I also found some other apis not passed into the inner function, such as window.Range...
So do you know how to resolve my issue? and you can take a look at my another linked issue: appium/appium-remote-debugger#383, I also have the "_" override because of this.Is there a good way to fix it?

@Jabbar2010
Copy link

Sorry, updated: appium/appium-remote-debugger#383 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: selenium seems to override _, breaking another package
4 participants