[java] improve warning when CDP version not found #12880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titusfortner
changed the title
titusfortner
changed the title
diemol
reviewed
Oct 6, 2023
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## trunk #12880 +/- ##
=======================================
Coverage 56.51% 56.51%
=======================================
Files 86 86
Lines 5255 5255
Branches 187 187
=======================================
Hits 2970 2970
Misses 2098 2098
Partials 187 187 ☔ View full report in Codecov by Sentry. |
aguspe
pushed a commit
to aguspe/selenium
that referenced
this pull request
Oct 22, 2023
* [java] improve warning when CDP version not found * Update java/src/org/openqa/selenium/devtools/CdpVersionFinder.java * fix linting issues --------- Co-authored-by: Diego Molina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds what action user should take to warning message
Motivation and Context
Resolves #12831
If we are going to log a warning, we should tell users what they need to do to remove the warning.
The alternative is to log this as
FINEinstead ofWARN. I slightly prefer the logging message because weird things *could happen, and updating to a new version of Selenium isn't a bad thing. But it does encourage us to release before Production Chrome is out. 😂