Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Add javadoc to support event classes #13199

Merged

Conversation

LogicOscar
Copy link
Contributor

@LogicOscar LogicOscar commented Nov 24, 2023

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

adds javadoc. extension of #12578

Description

Motivation and Context

more documentation. Added remote as a dep due to the method ResetInputState

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [z] I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c806757) 57.53% compared to head (5948464) 57.53%.
Report is 1 commits behind head on trunk.

❗ Current head 5948464 differs from pull request most recent head 563d81b. Consider uploading reports for the commit 563d81b to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #13199   +/-   ##
=======================================
  Coverage   57.53%   57.53%           
=======================================
  Files          86       86           
  Lines        5310     5310           
  Branches      221      221           
=======================================
  Hits         3055     3055           
  Misses       2034     2034           
  Partials      221      221           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@titusfortner titusfortner added this to the 4.16 milestone Nov 27, 2023
@titusfortner titusfortner merged commit 240e17b into SeleniumHQ:trunk Nov 29, 2023
38 of 39 checks passed
LogicOscar added a commit to LogicOscar/selenium that referenced this pull request Nov 29, 2023
* add javadoc to decorator and listener classes

* remove google common dep

* re add input state

* add remote webdriver dep

---------

Co-authored-by: Titus Fortner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants