-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[java] Add missing support events for Web Driver Listener #13210
Conversation
* @param driver WebDriver | ||
*/ | ||
default void afterWindow( | ||
WebDriver.TargetLocator targetLocator, String nameOrHandle, WebDriver driver) {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would you mind adding hooks for all methods from TargetLocator
?
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## trunk #13210 +/- ##
=======================================
Coverage 58.48% 58.48%
=======================================
Files 86 86
Lines 5270 5270
Branches 220 220
=======================================
Hits 3082 3082
Misses 1968 1968
Partials 220 220 ☔ View full report in Codecov by Sentry. |
I think we want to add for everything in this: https://github.com/seleniumhq/selenium/blob/trunk/java/src/org/openqa/selenium/WebDriver.java#L451 |
@valfirst & @RevealOscar thanks for your work and interest on this. Just sending a reminder that we want to get this into the next release if either of you have bandwidth to work on it this week. Thanks again. |
For my understanding: |
Yes it pulls the name of the actual method being called, which is window() |
@valfirst & @RevealOscar another ping on getting this added before 4.17 release, which will be "soon" |
@titusfortner I don't have permissions to work on this PR. if @RevealOscar doesn't have capacity to complete the PR, I would merge it as is (it's better than nothing). Then next contributor can add missing functionalities in a separate PR. |
@RevealOscar could you please resolve the conflicts and then I can merge this? |
it was just imports conflicting, if there's a problem RBE will fail 😂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you all!
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
adds explicit target locator events to the listener support classes. This can already be done implicitly since events can resolve to the web driver instance but this exposes these events explicitly
Motivation and Context
Types of changes
Checklist