Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py] deprecate FirefoxBinary class #13476

Merged
merged 2 commits into from
Jan 21, 2024
Merged

[py] deprecate FirefoxBinary class #13476

merged 2 commits into from
Jan 21, 2024

Conversation

titusfortner
Copy link
Member

Description

Deprecates the class and the properties on Firefox Options that is the only place the class is used

Motivation and Context

The class was created to manage starting and stopping the browser, which has not been necessary since the move to geckodriver. It is currently only used for storing the location of the browser, which is already duplicated behavior of binary_location() method.

Note: making use of the new deprecated annotation which is nice.

@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (19df7bb) 58.37% compared to head (df773bf) 58.46%.

❗ Current head df773bf differs from pull request most recent head 3d241f7. Consider uploading reports for the commit 3d241f7 to get more accurate results

Files Patch % Lines
py/selenium/webdriver/firefox/options.py 83.33% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #13476      +/-   ##
==========================================
+ Coverage   58.37%   58.46%   +0.08%     
==========================================
  Files          86       86              
  Lines        5266     5270       +4     
  Branches      222      220       -2     
==========================================
+ Hits         3074     3081       +7     
+ Misses       1970     1969       -1     
+ Partials      222      220       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pass in location of firefox with binary_location property in Options class
@titusfortner titusfortner merged commit 0f1c753 into trunk Jan 21, 2024
14 checks passed
@titusfortner titusfortner deleted the py_ff_bin branch January 21, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants