Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bazel]: Bump rules_protobuf to avoid warning about maven namespace #14891

Merged
merged 3 commits into from
Dec 12, 2024
Merged

[bazel]: Bump rules_protobuf to avoid warning about maven namespace #14891

merged 3 commits into from
Dec 12, 2024

Conversation

shs96c
Copy link
Member

@shs96c shs96c commented Dec 11, 2024

No description provided.

@qodo-merge-pro Qodo Merge Pro
Copy link
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Version Update
Major version bump of protobuf from 21.7 to 29.1 - validate compatibility and any breaking changes

@qodo-merge-pro Qodo Merge Pro
Copy link
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

@shs96c
Copy link
Member Author

shs96c commented Dec 12, 2024

The failing test also fails on trunk, and so is likely unrelated to this change.

@shs96c shs96c merged commit 7cde7f8 into SeleniumHQ:trunk Dec 12, 2024
8 of 9 checks passed
@shs96c shs96c deleted the bump-protobuf branch December 12, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Review effort [1-5]: 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shs96c