Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small refactoring to RemoteWebDriver: remove code duplication in a constructor #8141

Merged

Conversation

alb-i986
Copy link
Contributor

I've just noticed this small code duplication, and thought to open a PR.

I haven't had the chance to run the tests unfortunately.
I followed the setup instructions for bazel but had some troubles. I'm on osx 10.10, which is deprecated, so maybe that's the problem.

Cheers

Description

Clean code: small refactoring to RemoteWebDriver to remove code duplication in the constructor that takes only a Capabilities object.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented Mar 27, 2020

CLA assistant check
All committers have signed the CLA.

@shs96c
Copy link
Member

shs96c commented Mar 31, 2020

Hi! Thanks for this change. It's always nice to remove some duplication :) Merging now!

@shs96c shs96c merged commit 5bad273 into SeleniumHQ:master Mar 31, 2020
@alb-i986
Copy link
Contributor Author

alb-i986 commented Apr 1, 2020

Thank you @shs96c
My pleasure!
Cheers

@alb-i986 alb-i986 deleted the refactoring-RemoteWebDriver-constructor branch April 3, 2021 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants