change access modifier of RemoteWebDriver.execute method. #8344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have extended RemoteWebDriver and added more capabilities by extending RemoteWebDriver. We have overridden below methods.
```
protected Response execute(String driverCommand, Map<String, ?> parameters) {}
protected Response execute(String command) {}
```
Now these method has been replaced by `CommandPayload` arguments, these need to be a protected method to support override. Earlier it was support in selenium version 2 and 3.
|
|
diemol
approved these changes
May 26, 2020
There was a problem hiding this comment.
Thank you @amitbhoraniya, congratulations on your first contribution! We hope to see many more 🎉
8 tasks
titusfortner
pushed a commit
to titusfortner/selenium
that referenced
this pull request
Aug 13, 2020
We have extended RemoteWebDriver and added more capabilities by extending RemoteWebDriver. We have overridden below methods.
```
protected Response execute(String driverCommand, Map<String, ?> parameters) {}
protected Response execute(String command) {}
```
Now these method has been replaced by `CommandPayload` arguments, these need to be a protected method to support override. Earlier it was support in selenium version 2 and 3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have extended
RemoteWebDriverand added more capabilities by extending RemoteWebDriver. We have overridden below methods.Now these methods has been replaced by
CommandPayloadargument, these need to be aprotectedmethod to support override. Earlier overridden support was there in selenium version 2 and 3.Motivation and Context
This is blocker who have extended RemoteWebDriver in their libraries. This change supports migration to selenium 4.
Even now other execute methods are
protected, so I don't find any reason to make this methoddefault.Types of changes
Checklist