[py] PEP 484 type hints for selenium.webdriver.remote.errorhandler #9605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
| @@ -133,7 +139,7 @@ def check_response(self, response): | |||
| pass | |||
|
|
|||
| if status in ErrorCode.NO_SUCH_ELEMENT: | |||
| exception_class = NoSuchElementException | |||
| exception_class: Type[WebDriverException] = NoSuchElementException | |||
There was a problem hiding this comment.
Does line 144 need this hint too?
There was a problem hiding this comment.
And carried on through the file
There was a problem hiding this comment.
@AutomatedTester the type hint will be applied to all subsequent assignments. I agree though this type declaration is misleading and unclear; I've moved it to be in a separate line before the status checks. The line will be ignored by the interpreter and is only used for type hinting.
hoefling
force-pushed
the
PEP-484/webdriver-remote-errorhandler
branch
from
41201c0 to
107c173
Compare
Signed-off-by: oleg.hoefling <[email protected]>
Signed-off-by: oleg.hoefling <[email protected]>
… checks Signed-off-by: oleg.hoefling <[email protected]>
hoefling
force-pushed
the
PEP-484/webdriver-remote-errorhandler
branch
from
107c173 to
cea2d95
Compare
AutomatedTester
approved these changes
Jul 16, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds type hints to
selenium.webdriver.remote.errorhandler.Motivation and Context
This is a follow-up of #9482 to address #9480.
Types of changes
Checklist