Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update AddCourse form to use fileUrl and thumbnailS3Key instead of imageUrl #342

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

typeWolffo
Copy link
Member

@typeWolffo typeWolffo commented Jan 8, 2025

Jira issue(s)

LC-546

Overview

  • fixed a bug that resulted in course thumbnails being sent to the course form with the wrong key
  • fixed a bug that resulted in an image signed with a url being saved instead of the s3 key

@typeWolffo typeWolffo added the review me 👀 PR is ready to be reviewed label Jan 8, 2025
@typeWolffo typeWolffo self-assigned this Jan 8, 2025
@typeWolffo typeWolffo marked this pull request as ready for review January 8, 2025 16:58
Copy link
Collaborator

@wielopolski wielopolski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG 🍻

const watchedImageUrl = form.watch("imageUrl");
const imageUrl = form.getValues("imageUrl");
const watchedImageUrl = form.watch("fileUrl");
const fileUrl = form.getValues("fileUrl");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe can we use thumbnailUrl?

@typeWolffo typeWolffo merged commit 97f9c90 into main Jan 8, 2025
5 of 6 checks passed
@typeWolffo typeWolffo deleted the jw_fix_lc-546_create_course_missing_thumbnail branch January 8, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me 👀 PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants