feat(Form): safely prevent default on submit (#1786)

Semantic-Org · Jun 22, 2017 · 65fd10c · 65fd10c
1 parent c196143
commit 65fd10c
Show file tree

Hide file tree

Showing 12 changed files with 958 additions and 337 deletions.
diff --git a/docs/app/Components/IconSearch/IconSearch.js b/docs/app/Components/IconSearch/IconSearch.js
@@ -146,7 +146,7 @@ export default class IconSearch extends Component {
     return (
       <Grid columns={1} padded textAlign='center' style={gridStyle}>
         <Grid.Column>
-          <Form onSubmit={(e) => e.preventDefault()}>
+          <Form>
             <Form.Group inline>
               <Form.Input
                 id='docs-icon-set-input'

diff --git a/docs/app/Examples/collections/Form/Usage/FormExampleCaptureValues.js b/docs/app/Examples/collections/Form/Usage/FormExampleCaptureValues.js
@@ -7,7 +7,6 @@ class FormExampleCaptureValues extends Component {
   handleChange = (e, { name, value }) => this.setState({ [name]: value })
 
   handleSubmit = e => {
-    e.preventDefault()
     const { name, email } = this.state
 
     this.setState({ submittedName: name, submittedEmail: email })

diff --git a/docs/app/Examples/collections/Form/Usage/FormExampleClearOnSubmit.js b/docs/app/Examples/collections/Form/Usage/FormExampleClearOnSubmit.js
@@ -6,10 +6,7 @@ class FormExampleClearOnSubmit extends Component {
 
   handleChange = (e, { name, value }) => this.setState({ [name]: value })
 
-  handleSubmit = e => {
-    e.preventDefault()
-    this.setState({ email: '', name: '' })
-  }
+  handleSubmit = e => this.setState({ email: '', name: '' })
 
   render() {
     const { name, email } = this.state

diff --git a/docs/app/Examples/views/Comment/Content/CommentExampleReplyForm.js b/docs/app/Examples/views/Comment/Content/CommentExampleReplyForm.js
@@ -14,7 +14,7 @@ const CommentExampleReplyForm = () => (
         <Comment.Actions>
           <Comment.Action active>Reply</Comment.Action>
         </Comment.Actions>
-        <Form reply onSubmit={e => e.preventDefault()}>
+        <Form reply>
           <Form.TextArea />
           <Button content='Add Reply' labelPosition='left' icon='edit' primary />
         </Form>

diff --git a/docs/app/Examples/views/Comment/Content/CommentExampleReplyFormOuter.js b/docs/app/Examples/views/Comment/Content/CommentExampleReplyFormOuter.js
@@ -34,7 +34,7 @@ const CommentExampleReplyFormOuter = () => (
       </Comment.Content>
     </Comment>
 
-    <Form reply onSubmit={e => e.preventDefault()}>
+    <Form reply>
       <Form.TextArea />
       <Button content='Add Comment' labelPosition='left' icon='edit' primary />
     </Form>

diff --git a/docs/app/Examples/views/Comment/Types/CommentExampleComment.js b/docs/app/Examples/views/Comment/Types/CommentExampleComment.js
@@ -68,7 +68,7 @@ const CommentExampleComment = () => (
       </Comment.Content>
     </Comment>
 
-    <Form reply onSubmit={e => e.preventDefault()}>
+    <Form reply>
       <Form.TextArea />
       <Button content='Add Reply' labelPosition='left' icon='edit' primary />
     </Form>

diff --git a/docs/app/Examples/views/Comment/Variations/CommentExampleMinimal.js b/docs/app/Examples/views/Comment/Variations/CommentExampleMinimal.js
@@ -65,7 +65,7 @@ const CommentExampleMinimal = () => (
       </Comment.Content>
     </Comment>
 
-    <Form reply onSubmit={e => e.preventDefault()}>
+    <Form reply>
       <Form.TextArea />
       <Button content='Add Reply' labelPosition='left' icon='edit' primary />
     </Form>

diff --git a/docs/app/Examples/views/Comment/Variations/CommentExampleThreaded.js b/docs/app/Examples/views/Comment/Variations/CommentExampleThreaded.js
@@ -65,7 +65,7 @@ const CommentExampleThreaded = () => (
       </Comment.Content>
     </Comment>
 
-    <Form reply onSubmit={e => e.preventDefault()}>
+    <Form reply>
       <Form.TextArea />
       <Button content='Add Reply' labelPosition='left' icon='edit' primary />
     </Form>