Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progress: indicating bar displaying wrong color with decimal value #1671

Closed
patrickgaskill opened this issue May 12, 2017 · 0 comments
Closed

Progress: indicating bar displaying wrong color with decimal value #1671

patrickgaskill opened this issue May 12, 2017 · 0 comments
Labels
bug

Comments

@patrickgaskill
Copy link
Contributor

Steps

<Progress indicating value={8.28} />

Expected Result

The progress bar should be the @indicatingFirstColor, a red color.

Actual Result

The progress bar is @indicatingFifthLabelColor, a green color.

Version

0.68.3

Testcase

http://codepen.io/patrickgaskill/pen/xdWMwY
@patrickgaskill patrickgaskill changed the title Indicating Progress bar displaying wrong color when given a decimal value Progress: indicating bar displaying wrong color with decimal value May 12, 2017
patrickgaskill added a commit to patrickgaskill/Semantic-UI-React that referenced this issue May 12, 2017
@patrickgaskill
fix(Progress): Floor data-percent attribute
e7375e0 
Floor the data-percent attribute so Semantic UI CSS works as expected.

Fixes Semantic-Org#1671
@patrickgaskill patrickgaskill mentioned this issue May 12, 2017
Merged
patrickgaskill pushed a commit to patrickgaskill/Semantic-UI-React that referenced this issue May 12, 2017
test(Progress): test for flooring data-percent (Semantic-Org#1672)
6476194 
Related to Semantic-Org#1671
patrickgaskill added a commit to patrickgaskill/Semantic-UI-React that referenced this issue May 12, 2017
@patrickgaskill
test(Progress): test for flooring data-percent (Semantic-Org#1672)
c864861 
Related to Semantic-Org#1671
levithomason pushed a commit that referenced this issue May 13, 2017
@patrickgaskill @levithomason
fix(Progress): use floor for data-percent attribute (#1672)
8dbb7e5 
* fix(Progress): Floor data-percent attribute

Floor the data-percent attribute so Semantic UI CSS works as expected.

Fixes #1671

* test(Progress): test for flooring data-percent (#1672)

Related to #1671
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@patrickgaskill @layershifter