Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for error messages in <Form.Field/> #3602

Closed
bubunyo opened this issue May 9, 2019 · 1 comment · Fixed by #3603
Closed

Add support for error messages in <Form.Field/> #3602

bubunyo opened this issue May 9, 2019 · 1 comment · Fixed by #3603
Labels

Comments

@bubunyo
Copy link
Contributor

bubunyo commented May 9, 2019

Feature Request

Problem description

Some errors might require the developer to give the user some context on what went wrong. And this will most likely happen by showing an error message. But the Form.Field component lacks this functionality.

Proposed solution

To extend the error prop to not only accepts bools, but also strings to be shown as error messages. There is currently no css to support this feature.

MVP

Something as simple as this
Screenshot 2019-05-09 at 19 26 13
Screenshot 2019-05-09 at 19 16 54

@welcome
Copy link

welcome bot commented May 9, 2019

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you've completed all the fields in the issue template so we can best help.

We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

bubunyo pushed a commit to bubunyo/Semantic-UI-React that referenced this issue May 9, 2019
layershifter pushed a commit that referenced this issue Jun 28, 2019
* feat(Ref): add support for error messages in <Form.Field/> (#3405)

* feat(Ref): add support for error messages in <Form.Field/> (#3602)

* fix(reff) update error proptype to show to to reflect in docs

* use Label component

* remove only

* update descriptions and types

* fix typings issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant