fix(Dropdown): display icon in selected text

[rbideau]

First attempt at fixing #1147

[levithomason]

@rbideau what is the status on this one?

[rbideau]

I didn't spent any time on it lately, but I'm still stuck at the same point as I said in #1147.

It's in line 990 of src/modules/Dropdown/Dropdown.js of this PR.

[levithomason]

The DropdownItem's create method does not set children:

https://github.com/Semantic-Org/Semantic-UI-React/pull/1172/files#diff-39c9e693d6f8be797267ef676395ef14R171

-DropdownItem.create = createShorthandFactory(DropdownItem, value => value)
+DropdownItem.create = createShorthandFactory(DropdownItem, children => ({ children }))

The callback above is invoked when the shorthand value is a string, number, or an array. This change will map those values to the children of the DropdownItem so that:

DropdownItem.create('item 1')
// => <DropdownItem>item 1</DropdownItem>

[codecov-io]

Codecov Report

Merging #1172 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1172      +/-   ##
==========================================
+ Coverage   95.88%   95.88%   +<.01%     
==========================================
  Files         879      879              
  Lines        4881     4887       +6     
==========================================
+ Hits         4680     4686       +6     
  Misses        201      201

Impacted Files	Coverage Δ
src/modules/Dropdown/Dropdown.js	100% <100%> (ø)	✅
src/modules/Dropdown/DropdownItem.js	100% <100%> (ø)	✅

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0d8011...8290b49. Read the comment docs.

[rbideau]

This doesn't work because when there is an icon, rest is an object and then mapValueToProps is not called in factories/createShorthand

[levithomason]

This PR has gotten stale and seems abandoned. Closing for housekeeping. Still happy to merge an updated and complete community PR.