Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Checkbox): fix value prop types #1694

Merged
merged 2 commits into from
May 22, 2017

Conversation

fabien0102
Copy link
Contributor

Just a little fix, PropTypes doesn't match typescript definition into Checkbox.js.

// Checkbox.d.ts:79

/** The HTML input value. */
  value?: number|string;

@codecov-io
Copy link

codecov-io commented May 22, 2017

Codecov Report

Merging #1694 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1694   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files         141      141           
  Lines        2412     2412           
=======================================
  Hits         2406     2406           
  Misses          6        6
Impacted Files Coverage Δ
src/modules/Checkbox/Checkbox.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bacf4b7...55b00b6. Read the comment docs.

Copy link
Member

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed lint issues. LGTM, thanks for PR

@levithomason levithomason merged commit 768a808 into Semantic-Org:master May 22, 2017
@levithomason
Copy link
Member

Released in [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants