Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(TextArea): fix typings definition #1989

Merged
merged 1 commit into from
Aug 27, 2017
Merged

fix(TextArea): fix typings definition #1989

merged 1 commit into from
Aug 27, 2017

Conversation

pierre-H
Copy link
Contributor

Fix false definition of TextArea

@pierre-H pierre-H changed the title Fix TextArea type fix(TextArea) Fix prop definition Aug 21, 2017
@layershifter layershifter changed the title fix(TextArea) Fix prop definition fix(TextArea): fix prop definition in typings Aug 21, 2017
layershifter
layershifter approved these changes Aug 21, 2017
View reviewed changes
Copy link
Member

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pierre-H Thanks!

@layershifter layershifter mentioned this pull request Aug 24, 2017
Closed
@thchia
Copy link

thchia commented Aug 25, 2017 •
edited
Loading

Should focus be an optional property?

@layershifter
Copy link
Member

focus isn't React's prop there, it's a class method. So, definition is correct and this will be work:

 <TextArea ref={c => c.focus()} />

@thchia
Copy link

thchia commented Aug 25, 2017

Oops you are absolutely right 🙃

@levithomason levithomason merged commit 621ce08 into Semantic-Org:master Aug 27, 2017
@levithomason levithomason changed the title fix(TextArea): fix prop definition in typings fix(TextArea): fix typings definition Aug 27, 2017
@levithomason
Copy link
Member

Released in [email protected]

@pierre-H pierre-H deleted the patch-3 branch October 17, 2017 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@layershifter layershifter layershifter approved these changes

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pierre-H @thchia @layershifter @levithomason