feat(Dropdown): add direction prop
#2174
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2174 +/- ##
==========================================
+ Coverage 99.73% 99.76% +0.03%
==========================================
Files 151 151
Lines 2622 2606 -16
==========================================
- Hits 2615 2600 -15
+ Misses 7 6 -1
Continue to review full report at Codecov.
|
src/modules/Dropdown/Dropdown.js
Outdated
| @@ -115,6 +115,9 @@ export default class Dropdown extends Component { | |||
| ])), | |||
| ]), | |||
|
|
|||
| /** A dropdown can be positioned to the left */ | |||
| directionLeft: PropTypes.bool, | |||
There was a problem hiding this comment.
Please rename the prop to direction that will accept left as value.
src/modules/Dropdown/Dropdown.js
Outdated
| @@ -1298,6 +1302,7 @@ export default class Dropdown extends Component { | |||
| useKeyOnly(simple, 'simple'), | |||
| useKeyOnly(scrolling, 'scrolling'), | |||
| useKeyOnly(upward, 'upward'), | |||
| useKeyOnly(directionLeft, 'left'), | |||
There was a problem hiding this comment.
Please sort it in alphabetical order, i.e.:
useKeyOrValueAndKey(direction, 'direction'),
useKeyOrValueAndKey(pointing, 'pointing'),
There was a problem hiding this comment.
@luisbd Thanks for PR 👍 I've left some comments about naming
layershifter
changed the title
direction prop
|
This branch has a conflict that needs resolved. Also, let's update docs with the new prop as well, there's |
|
What is the status here? |
|
See #720, please refrain from status update requests. It makes it difficult to keep up with notifications and responses to bugs/feature requests. The best way to check on the status is to check the docs, issues, and PRs. We have no work or status available outside of this. |
This PR adds left directioning support to DropdownMenu.
Closes issue #1897