feat(Flag|Icon): use PureComponent instead of shallowEqual() #2842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## react-16 #2842 +/- ##
===========================================
Coverage ? 99.78%
===========================================
Files ? 160
Lines ? 2775
Branches ? 0
===========================================
Hits ? 2769
Misses ? 6
Partials ? 0
Continue to review full report at Codecov.
|
layershifter
added a commit
that referenced
this pull request
Jun 29, 2018
* breaking(Portal): use createPortal() API (#2755) * breaking(Portal): use createPortal() API * test(Portal): rewrite tests * test(Portal): rewrite tests * fix(Portal): mixed fixes in tests * fix(Portal): fix path of typings * feat(Flag|Icon): use PureComponent instead of shallowEqual() (#2842) * fix(IconSearch): remove prop * fix(PortalInner): remove meta * fix(Portal): fix broken test * fix(Modal): go away from rootNode * fix(Flag|Icon): remove unused import * feat(Portal): add `triggerRef` prop (#2902) * feat(Portal): add `triggerRef` prop * test(Portal): add test for `triggerRef` prop * fix(Popup): fix test * BREAKING(Accordion): refactor shorthand API to use AccordionPanel (#2904) * refactor(Accordion): simplify render with AccordionPanel * style(Accordion): add description * fix(tests): reenable throw on console.log() * style(mixed): lint issues in typings * fix yarn.lock * fix(ComponentDocLinks): add rel="noopener noreferrer" * revert styling changes * restore yarn.lock from master * style(Portal): remove render method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #2747.
This PR will also improve code coverage 👍