Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(package): add sideEffects: false for Webpack 4 #2941

Merged
merged 1 commit into from
Jun 23, 2018

Conversation

layershifter
Copy link
Member

Fixes #2589.

@codecov-io
Copy link

Codecov Report

Merging #2941 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2941   +/-   ##
=======================================
  Coverage   99.78%   99.78%           
=======================================
  Files         161      161           
  Lines        2760     2760           
=======================================
  Hits         2754     2754           
  Misses          6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e90cc89...f410a56. Read the comment docs.

@layershifter layershifter merged commit 1f01e14 into master Jun 23, 2018
@layershifter layershifter deleted the chore/side-effects branch June 23, 2018 08:49
@levithomason
Copy link
Member

Released in [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants