Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dropdown): allow defaultValue to be a boolean #2972

Conversation

leonardosul
Copy link
Contributor

A previous fix allowed using booleans as options for dropdowns. This adds the ability to also use a boolean as the defaultValue for a dropdown.

Booleans currently work as default value for dropdowns, but this change removes annoying console errors about propType errors.

A previous fix allowed using booleans as options for dropdowns. This adds the ability to also use a boolean as the defaultValue for a dropdown.
@welcome
Copy link

welcome bot commented Jul 3, 2018

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@layershifter layershifter changed the title fix(elements): allows a dropdown default value to be a boolean. fix(Dropdown): allow defaultValue to be a boolean Jul 3, 2018
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@1d795bc). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2972   +/-   ##
=========================================
  Coverage          ?   99.81%           
=========================================
  Files             ?      163           
  Lines             ?     2738           
  Branches          ?        0           
=========================================
  Hits              ?     2733           
  Misses            ?        5           
  Partials          ?        0
Impacted Files Coverage Δ
src/modules/Dropdown/Dropdown.js 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d795bc...89b5bbb. Read the comment docs.

@layershifter layershifter merged commit 33a49da into Semantic-Org:master Jul 3, 2018
@welcome
Copy link

welcome bot commented Jul 3, 2018

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@leonardosul leonardosul deleted the fix/dropdown-default-value-boolean branch July 3, 2018 09:56
@levithomason
Copy link
Member

Released in [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants