Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Icon): add 'file text outline' type #2993

Merged

Conversation

paulkoegel-wessels
Copy link
Contributor

@paulkoegel-wessels paulkoegel-wessels commented Jul 10, 2018

Icon "file text outline" exists in the code but not in the SemanticICONS type.

This PR adds the missing string literal to the SemanticICONS type as well as SUI.js.

Left (highlighted):
<Icon name="file text outline" />

Right:
<Icon name="file text" />

sh-602-prod-fr2 2018-07-10 12-38-17

@welcome
Copy link

welcome bot commented Jul 10, 2018

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

Copy link
Member

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add it into SUI.js, too.

@codecov-io
Copy link

codecov-io commented Jul 10, 2018

Codecov Report

Merging #2993 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2993   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files         163      163           
  Lines        2743     2743           
=======================================
  Hits         2742     2742           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22e571e...42c19eb. Read the comment docs.

@layershifter layershifter changed the title index.d.ts: SemanticICONS: add 'file text outline' fix(Icon): add 'file text outline' type Jul 10, 2018
@layershifter layershifter merged commit 972b999 into Semantic-Org:master Jul 10, 2018
@welcome
Copy link

welcome bot commented Jul 10, 2018

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@levithomason
Copy link
Member

Released in [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants