-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Icon): add 'file text outline' type #2993
fix(Icon): add 'file text outline' type #2993
Conversation
💖 Thanks for opening this pull request! 💖 Here is a list of things that will help get it across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add it into SUI.js
, too.
Codecov Report
@@ Coverage Diff @@
## master #2993 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 163 163
Lines 2743 2743
=======================================
Hits 2742 2742
Misses 1 1 Continue to review full report at Codecov.
|
Released in |
Icon "file text outline" exists in the code but not in the
SemanticICONS
type.This PR adds the missing string literal to the
SemanticICONS
type as well asSUI.js
.Left (highlighted):
<Icon name="file text outline" />
Right:
<Icon name="file text" />