docs(build): fix reloading of examples sources #3075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
commented
Aug 7, 2018
|
|
||
| const filename = path.resolve(__dirname, '..', 'exampleSources.json') | ||
|
|
||
| const getExampleSources = () => JSON.parse(fs.readFileSync(filename)) |
There was a problem hiding this comment.
require() will cache an object, so it will not changed on after rebuild.
layershifter
commented
Aug 7, 2018
| @@ -15,7 +15,8 @@ const { paths } = config | |||
| const g = loadPlugins() | |||
| const { log } = g.util | |||
|
|
|||
| const handleWatchChange = e => log(`File ${e.path} was ${e.type}, running tasks...`) | |||
| const handleWatchChange = filename => | |||
| log(`File ${path.basename(filename)} was changed, running tasks...`) | |||
There was a problem hiding this comment.
gulp's API was changed, now message works ^_^
Codecov Report
@@ Coverage Diff @@
## master #3075 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 163 163
Lines 2739 2739
=======================================
Hits 2737 2737
Misses 2 2Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title is obvious.