chore(build): fixes for UMD build #3085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksandr Fediashov <[email protected]>
layershifter
commented
Aug 13, 2018
| @@ -31,7 +32,8 @@ const plugins = [ | |||
| [ | |||
| 'transform-react-remove-prop-types', | |||
| { | |||
| mode: 'wrap', | |||
| mode: isUMDBuild ? 'remove' : 'wrap', | |||
| removeImport: isUMDBuild, | |||
There was a problem hiding this comment.
Remove propTypes fully from UMD build
layershifter
commented
Aug 13, 2018
| @@ -15,8 +15,8 @@ | |||
| "scripts": { | |||
| "build": "cross-env NODE_ENV=production gulp build", | |||
| "build:changelog": "github_changelog_generator --no-issues --no-unreleased --release-branch master --since-tag $(git describe --abbrev=0 --tags $(git rev-parse HEAD~300))", | |||
| "build:docs": "gulp --series dll build:docs", | |||
| "build:dist": "gulp --series dll build:dist", | |||
There was a problem hiding this comment.
We don't need dll in dist and docs
Codecov Report
@@ Coverage Diff @@
## master #3085 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 163 163
Lines 2739 2739
=======================================
Hits 2737 2737
Misses 2 2Continue to review full report at Codecov.
|
layershifter
commented
Aug 13, 2018
| new webpack.NoEmitOnErrorsPlugin(), | ||
| ) | ||
| } | ||
|
|
There was a problem hiding this comment.
We are using react-static now, so we don't use __DEV__ variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3079.