Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Dropdown): noResultsMessage prop can be a node #3177

Merged

Conversation

lazazivkovic
Copy link
Contributor

Relates to #3175

@welcome
Copy link

welcome bot commented Sep 28, 2018

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-io
Copy link

Codecov Report

Merging #3177 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3177   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         163      163           
  Lines        2746     2746           
=======================================
  Hits         2744     2744           
  Misses          2        2
Impacted Files Coverage Δ
src/modules/Dropdown/Dropdown.js 99.75% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 663d44f...551bae7. Read the comment docs.

@levithomason
Copy link
Member

Awesome, thanks for the well-documented issue and PR!

@levithomason levithomason merged commit 520accc into Semantic-Org:master Nov 30, 2018
@welcome
Copy link

welcome bot commented Nov 30, 2018

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@lazazivkovic lazazivkovic deleted the feat/dropdown-no-results branch January 8, 2019 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants