Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Sidebar): add target prop #3191

Merged
merged 2 commits into from
Oct 3, 2018
Merged

feat(Sidebar): add target prop #3191

merged 2 commits into from
Oct 3, 2018

Conversation

layershifter
Copy link
Member

Why?

The target prop allows to pass element to which will be attached event listener. This allows to customize closable area, defaults to document.

@codecov-io
Copy link

codecov-io commented Oct 3, 2018

Codecov Report

Merging #3191 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3191   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         169      169           
  Lines        2790     2790           
=======================================
  Hits         2788     2788           
  Misses          2        2
Impacted Files Coverage Δ
src/modules/Sidebar/Sidebar.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5697d4...d03a898. Read the comment docs.

Signed-off-by: Oleksandr Fediashov <[email protected]>
@layershifter layershifter merged commit a779351 into master Oct 3, 2018
@layershifter layershifter deleted the feat/sidebar-target branch October 3, 2018 10:49
@levithomason
Copy link
Member

Released in [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants