docs(Ads): fix multiple ads

[layershifter]

Issue source

There was a strange tweet about issue with ads, https://twitter.com/ARedHerring_/status/1041044450288590848

I haven't ever seen this, looks really ugly 👎 I tried to find the issue and it seems that it comes from the Carbon's code, it adds multiple adds sometimes.

[layershifter]

@levithomason can you please take a look? Possible there is a solution without dirty tricks?

[codecov-io]

Codecov Report

Merging #3215 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3215   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         169      169           
  Lines        2790     2790           
=======================================
  Hits         2788     2788           
  Misses          2        2

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87f467a...da1490a. Read the comment docs.

[levithomason]

Thanks, this was also reported to me via email. The refresh method removes the ad then creates a new one. If there is no ad in the div, it will insert one. What is happening is that componentWillUpdate is called in rapid succession calling refresh multiple times rapidly. This removes and replaces the ad on the first call, but before it is loaded the second refresh is also called which fetches a second ad.

I will take a look at the changes here and confirm the fix or update it.

[levithomason]

• Added check to ensure we don't duplicate fetch ads.
• Made it smaller and better styled, was taking up a lot of real estate.
• Improved sidebar ux and layout to help with real estate.

[levithomason]

Released in [email protected].