Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dropdown): prevent calling onChange unless value changed #3391

Merged
merged 2 commits into from
Feb 4, 2019
Merged

Conversation

zarend
Copy link
Contributor

@zarend zarend commented Jan 18, 2019

For the Dropdown component, ensures that onChange is called only if the user selectes a value that is different from the current value of the Dropdown. This is so we can have parity with the regular HTML select.

For the Dropdown component, ensures that onChange is called only if the user selectes a value that is different from the current value of the Dropdown. This is so we can have parity with the regular HTML select.
@welcome
Copy link

welcome bot commented Jan 18, 2019

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-io
Copy link

codecov-io commented Jan 18, 2019

Codecov Report

Merging #3391 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3391      +/-   ##
==========================================
+ Coverage   99.89%   99.89%   +<.01%     
==========================================
  Files         170      170              
  Lines        2809     2812       +3     
==========================================
+ Hits         2806     2809       +3     
  Misses          3        3
Impacted Files Coverage Δ
src/modules/Dropdown/Dropdown.js 99.76% <100%> (ø) ⬆️
src/modules/Popup/Popup.js 99.23% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1be2d4...4ca878c. Read the comment docs.

@spencer-brown
Copy link

awesome. thanks, @zarend !

@levithomason levithomason merged commit f735a58 into Semantic-Org:master Feb 4, 2019
@welcome
Copy link

welcome bot commented Feb 4, 2019

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@levithomason
Copy link
Member

Excellent work, thank you much!

@levithomason
Copy link
Member

Released in [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants