Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dropdown): retain focus on the input if the Dropdown receives a click #3422

Merged
merged 6 commits into from
Feb 11, 2019

Conversation

jongsue
Copy link
Contributor

@jongsue jongsue commented Feb 8, 2019

fix #3346

@welcome
Copy link

welcome bot commented Feb 8, 2019

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-io
Copy link

codecov-io commented Feb 8, 2019

Codecov Report

Merging #3422 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3422      +/-   ##
==========================================
+ Coverage   99.89%   99.92%   +0.03%     
==========================================
  Files         172      172              
  Lines        2835     2837       +2     
==========================================
+ Hits         2832     2835       +3     
+ Misses          3        2       -1
Impacted Files Coverage Δ
src/modules/Dropdown/Dropdown.js 100% <100%> (+0.23%) ⬆️
src/modules/Checkbox/Checkbox.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4bf431...4b5032b. Read the comment docs.

@layershifter layershifter merged commit ab582ed into Semantic-Org:master Feb 11, 2019
@welcome
Copy link

welcome bot commented Feb 11, 2019

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@levithomason
Copy link
Member

Released in [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple select search dropdown input field is too small
4 participants