Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TextArea): Make TextArea's height shrink (#3418) #3436

Closed

Conversation

codrex
Copy link

@codrex codrex commented Feb 13, 2019

This fixes the issue reported here

Before

bug

After

fix

@welcome
Copy link

welcome bot commented Feb 13, 2019

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-io
Copy link

Codecov Report

Merging #3436 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3436      +/-   ##
==========================================
+ Coverage   99.92%   99.92%   +<.01%     
==========================================
  Files         172      172              
  Lines        2838     2839       +1     
==========================================
+ Hits         2836     2837       +1     
  Misses          2        2
Impacted Files Coverage Δ
src/addons/TextArea/TextArea.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8365c90...3f2c051. Read the comment docs.

@layershifter
Copy link
Member

@codrex thank you for the PR, checked in Chrome.

Zoom 100%

Works fine.

zoom-100

Zoom 90%

Appears a scroll bar.

zoom-90

@codrex
Copy link
Author

codrex commented Feb 14, 2019

@layershifter You welcome. I will check this out.

…c-Org#3418)

  * add test to check for shrinking when newline deleted
@codrex codrex force-pushed the bug/text-area-auto-height-bug branch from 3f2c051 to 2843926 Compare February 14, 2019 15:10
@codrex
Copy link
Author

codrex commented Feb 14, 2019

fix2

@layershifter updates have been made to the PR. A scroll bar still appears and disappears at a given size. Going through the current implementation I discovered the same behavior.

@layershifter
Copy link
Member

layershifter commented Feb 26, 2019

@codrex thank you for your effort there, I really appreciate it 👍

However, I opened #3465 with the detailed description why I want to do that changes. Sorry for the late response, I wanted to hear the opinion from the team that uses SUIR very long time.

@codrex codrex deleted the bug/text-area-auto-height-bug branch March 2, 2019 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants