docs(Search): remove imports of other examples #3494
Conversation
…to docs/remove-imports-search
Codecov Report
@@ Coverage Diff @@
## master #3494 +/- ##
=======================================
Coverage 99.82% 99.82%
=======================================
Files 172 172
Lines 2804 2804
=======================================
Hits 2799 2799
Misses 5 5Continue to review full report at Codecov.
|
Perhaps. We have This may also be something we can do with lint rules. There is an eslint import plugin. We might be able to restrict imports via an .eslintrc in the doc examples directory. That would be easier to maintain. We can merge this for now 👍 |
| @@ -18,7 +18,7 @@ const SearchVariationsExamples = () => ( | |||
| /> | |||
| <ShorthandExample | |||
| title='Input' | |||
| description='A search can be passed an input via shorthand props.' | |||
| description='A search can receive an input via shorthand props.' | |||
|
Released in |
@levithomason I've been fiddling with this idea for a while, I can submit a PR soon! |
* docs(Search): Implement own standard custom. * docs(Search): Implement own category custom example. * docs(Search): Implement own example for fluid search. * docs(Search): Implement own example for aligned search. * docs(Search): Implement own example for input search and fix typo.
As discussed in #3479 , this PR remove imports in Search examples of other examples. This creates a bit of repetition, which doesn't feel very nice, but all sandboxes work now.
I wonder if it would make sense to add some kind of general test to assure that this won't repeat in other examples... 🤔