fix(Popup|Portal): do not close when mouse click was occurred inside

[mihai-dinculescu]

This PR is my proposed fix for #3554.

Afaik the onClick event provides no information whatsoever about the position where the mouse button was pressed down. For this reason I've added a listener for mouseDown and I'm storing the latest occurence of this event in the component.

I would like to also write a unit test but I'm not really sure how to go about mocking a click that originates in one place and ends in another.

[mihai-dinculescu]

I've updated domEvent.click to also fire mousedown and mouseup so that it mimicks reality.

[codecov-io]

Codecov Report

Merging #3575 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3575      +/-   ##
==========================================
- Coverage   99.81%   99.81%   -0.01%     
==========================================
  Files         174      174              
  Lines        2734     2733       -1     
==========================================
- Hits         2729     2728       -1     
  Misses          5        5

Impacted Files	Coverage Δ
src/addons/Portal/Portal.js	100% <100%> (ø)	⬆️
src/collections/Table/Table.js	100% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9a3418...25ca6ac. Read the comment docs.

[layershifter]

@joergbaier @mihai-dinculescu Thank you for addressing this 👍

We have a similar stuff in Dropdown with isMouseDown and I prefer to keep existing listeners with click instead of mouseup. So I am wondered, do we really need to use document.mouseup instead of document.click?

[mihai-dinculescu]

I don't see any way around using mousedown. click provides no information whatsoever about it.

However, I do see why we need to be more thoughtful before merging this. Touch gestures do not provide mousedown and mouseup events.

After further consideration, I now think that we should use mousedown in tandem with click, instead of mousedown and mouseup.

I should have a rework of this branch ready soon.

[mihai-dinculescu]

Ok @layershifter, it should look much better now!