Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Layouts): fix vertical alignment on LoginPage #3623

Merged
merged 2 commits into from
May 26, 2019

Conversation

ashvini-maurya
Copy link
Contributor

@ashvini-maurya ashvini-maurya commented May 25, 2019

The vertical alignment of login form is fixed.
Earlier the grid height was given 100% and now I changed grid height to 100vh. Now the login form will be always centered irresective of screen height.
This PR fixes this issue

Fixes #3620.

@welcome
Copy link

welcome bot commented May 25, 2019

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-io
Copy link

codecov-io commented May 25, 2019

Codecov Report

Merging #3623 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3623   +/-   ##
=======================================
  Coverage   99.81%   99.81%           
=======================================
  Files         174      174           
  Lines        2744     2744           
=======================================
  Hits         2739     2739           
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 951d7ce...7531127. Read the comment docs.

@layershifter layershifter changed the title login page vertical alignment issue fixed #3620 docs(Layouts): fix vertical alignment on LoginPage May 26, 2019
@layershifter layershifter merged commit e595719 into Semantic-Org:master May 26, 2019
@welcome
Copy link

welcome bot commented May 26, 2019

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

mbakiev pushed a commit to mbakiev/Semantic-UI-React that referenced this pull request Jun 17, 2019
* login page vertical alignment issue fixed Semantic-Org#3620

* Update LoginLayout.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: login example from official website is not laid out as expected
3 participants